fix: Handle undefined xhr.responseText to enable upload retries#2522
Merged
monkeyiq merged 1 commit intofilesender:development3from Jan 28, 2026
Merged
Conversation
Contributor
|
why not trim() rather than replace(\s) front and back? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a JavaScript crash that occurs during large file uploads, particularly in Firefox when network instability (HTTP/3/QUIC resets) causes XHR responses to be empty or undefined.
The Problem
When uploading large files, FileSender uses Terasender workers to upload chunks in parallel. If a network error occurs (timeout, connection reset, HTTP/3 instability), the XHR
responseTextproperty may beundefinedinstead of a string.The current code attempts to call
.replace()directly onresponseText:This causes a
TypeError: Cannot read property 'replace' of undefined, which:Affected files:
www/js/client.js(line 227) - General API error handlingwww/js/terasender/terasender_worker.js(line 508) - Chunk upload error handlingThe Solution
Added defensive null-checking before accessing
responseText:This ensures:
responseTextexists → Works exactly as beforeresponseTextis undefined/null → Uses empty string, preventing crashImpact
Files Modified
www/js/client.js(line 227)www/js/terasender/terasender_worker.js(line 508)Type of change
How Has This Been Tested?
Tested in production environment with Firefox where HTTP/3 network resets were causing upload failures on large files (500MB+). After applying the fix, uploads complete successfully with automatic retries when network hiccups occur.