Docker deployment for local testing#2520
Conversation
…efault; expose port 9000
…nt: hardcoded logon_url, logoff_url; init properties in AuditLog
WebSpider
left a comment
There was a problem hiding this comment.
Thanks for working on this!
After the short mail exchange on the devlist I had started to bump versions, but this is a lot more thorough, thanks!
I do have a few remarks, please see inline.
There was a problem hiding this comment.
It probably isnt a good idea to leave a certificate in a source tree. Given there is also a shell script in the same PR that recreates it, could we remove this and the private key?
There was a problem hiding this comment.
Could you please change including a complete file into including the patch to the original? This way it is better to see what actually has changed
You can then easily patch the already installed file from the tarball in the container
There was a problem hiding this comment.
Could you please change including a complete file into including the patch to the original? This way it is better to see what actually has changed
You can then easily patch the already installed file from the tarball in the container
…ia patch files; generate IdP certificate and update configuration from template; use .env file for docker and compose configuration
|
I think I have addressed now most of the remarks and also improved the deployment quite a bit.
You can try out the deployment by running The three patches that I have included are:
The (potential) todos are listed in the Readme.md file, but I hope the current changes are okay to merge into the dev branch. |
|
I have added |
|
The download count issue is fixed in development3 and so will be fixed in the next release (3.4). |
|
It looks like the third issue for |
|
Given that 3.4 will be needed for those 3 patches to be dropped I am thinking about merging this now and we can continue with updates (particularly for the patches) as newer releases arrive. |
This PR changes the scope of the provided docker example, reducing it to a simple local deployment running on http. It uses the Filesender 3.3 release, is based on a recent php-fpm image (php:8.5-fpm) and updates SimpleSAMLphp to 2.4.4. It also adds a few minor patches to the local deployment. Instructions on how to run the image have been updated in the readme file.