Merged
Conversation
This includes additional validation for creating transfers and guests.
It should not effect normal use but is intended to chase explicitly
nefarious use.
These options are enabled by default with the new settings
```
'advanced_validation_create_transfer' => true,
'advanced_validation_create_guest' => true,
'advanced_validation_token' => true,
'advanced_validation_user' => true,
'advanced_validation_principal' => true,
```
There may be teething issues so being able to toggle things on or off
is useful at the start. After a while these options may be removed and
the advanced validation will always be performed.
I would have REALLY liked to use a schema validation language or
framework to perform these tasks. Doing that is not inline with the
wishes of the FileSender board.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes additional validation for creating transfers and guests. It should not effect normal use but is intended to chase explicitly nefarious use.
These options are enabled by default with the new settings
There may be teething issues so being able to toggle things on or off is useful at the start. After a while these options may be removed and the advanced validation will always be performed.
I would have REALLY liked to use a schema validation language or framework to perform these tasks. Doing that is not inline with the wishes of the FileSender board.