UX: On OSX/Safari it seems lengthComputable is not set.#2324
Merged
monkeyiq merged 1 commit intofilesender:developmentfrom Jul 11, 2025
Merged
UX: On OSX/Safari it seems lengthComputable is not set.#2324monkeyiq merged 1 commit intofilesender:developmentfrom
monkeyiq merged 1 commit intofilesender:developmentfrom
Conversation
The evt.lengthComputable is false on osx/safari. This leads to the progressbar not being updated in the UI. The code doesn't actually need to use the total size from the evt message so if there is some indication of what is done we can update the progress anyway. This should allow a nice download progress message on OSX/Safari. Tested in an A/B on the current version of macos/safari as of today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evt.lengthComputable is false on osx/safari. This leads to the progressbar not being updated in the UI. The code doesn't actually need to use the total size from the evt message so if there is some indication of what is done we can update the progress anyway.
This should allow a nice download progress message on OSX/Safari.
Tested in an A/B on the current version of macos/safari as of today.