Skip to content

Possible to save storage subpath in database for easier migration.#2120

Merged
monkeyiq merged 1 commit intofilesender:development3from
monkeyiq:2025/feb/storage-store-subpath-per-file
Feb 16, 2025
Merged

Possible to save storage subpath in database for easier migration.#2120
monkeyiq merged 1 commit intofilesender:development3from
monkeyiq:2025/feb/storage-store-subpath-per-file

Conversation

@monkeyiq
Copy link
Copy Markdown
Contributor

@monkeyiq monkeyiq commented Feb 16, 2025

New option to allow the path from storage to be stored per file in the database. This is the first step towards allowing various settings like per day buckets and idp in the storage path to be changed and existing files continue to be downloadable.

This PR only optionally stores the path. A future PR will allow that information to be used and this allow storage settings to change and existing files (uploaded with this new
storage_filesystem_explicitly_store_subpath_per_file enabled) to continue to be downloaded in the face of settings changes.

This was inspired by #2119

@monkeyiq
Possible to save storage subpath in database for easier migration.
0fddf13 
New option to allow the path from storage to be stored per file in the
database. This is the first step towards allowing various settings
like per day buckets and idp in the storage path to be changed and
existing files continue to be downloadable.

This PR only optionally stores the path. A future PR will allow that
information to be used and this allow storage settings to change and
existing files (uploaded with this new
storage_filesystem_explicitly_store_subpath_per_file enabled) to
continue to be downloaded in the face of settings changes.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 16, 2025

If there are selenium UI results for this code they will be at filesenderuici@0fddf13

@monkeyiq monkeyiq merged commit 542750b into filesender:development3 Feb 16, 2025
2 of 6 checks passed
@madsi1m
Copy link
Copy Markdown
Contributor

madsi1m commented Feb 17, 2025

With this, it might just be better to have this forced, and backfill it, then we can remove these from Transfer:

        'storage_filesystem_per_day_buckets' => array(
            'type'    => 'bool',
            'null'    => false,
            'default' => false,
        ),
        'storage_filesystem_per_hour_buckets' => array(
            'type'    => 'bool',
            'null'    => false,
            'default' => false,
        ),
        'storage_filesystem_per_idp' => array(
            'type'    => 'bool',
            'null'    => false,
            'default' => false,
        ),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@monkeyiq @madsi1m