Skip to content

Bring back language dropdown behaviour from v2.x#2038

Merged
monkeyiq merged 1 commit intofilesender:development3from
AvesIT:2024/10/lang-dropdown
Apr 1, 2025
Merged

Bring back language dropdown behaviour from v2.x#2038
monkeyiq merged 1 commit intofilesender:development3from
AvesIT:2024/10/lang-dropdown

Conversation

@WebSpider
Copy link
Copy Markdown
Collaborator

@WebSpider WebSpider commented Oct 9, 2024

  • Filter duplicate languages
  • Only show if there are multiple languages configured

Fixes #1997

- Filter duplicate languages
- Only show if there are multiple languages configured
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2024

If there are selenium UI results for this code they will be at filesenderuici@ed5808b

@WebSpider WebSpider linked an issue Oct 9, 2024 that may be closed by this pull request
@WebSpider WebSpider marked this pull request as draft October 9, 2024 12:34
@WebSpider
Copy link
Copy Markdown
Collaborator Author

Re-reading my own PR made me realise there is a bit missing. Marking as draft.

@monkeyiq
Copy link
Copy Markdown
Contributor

Which bit is missing. It would be handy to know for subsequent updates and/or other PRs that try to do the same thing.

@monkeyiq
Copy link
Copy Markdown
Contributor

I may close this for now. If we know what is missing and what we need to do then this could be reopened.

@monkeyiq monkeyiq closed this Oct 28, 2024
@WebSpider WebSpider reopened this Mar 31, 2025
@github-actions
Copy link
Copy Markdown

If there are selenium UI results for this code they will be at filesenderuici@ed5808b

@WebSpider WebSpider marked this pull request as ready for review March 31, 2025 14:36
@WebSpider
Copy link
Copy Markdown
Collaborator Author

I tested this PR and it was fine after all.

@monkeyiq monkeyiq merged commit b9bf7f2 into filesender:development3 Apr 1, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI3: My Profile / Language lists langauges 2 or 3 times.

2 participants