Skip to content

Bug: Guest flow is missing mandatory recipient #2567

@WebSpider

Description

@WebSpider

In filesender 3.3

When sending a guest voucher with the following options:

  • Can only send to me: OFF
  • Send a link: OFF, send link via e-mail
  • Add me to recipients: OFF

When the guest user opens the voucher and chooses:

  • Add a file to the transfer
  • Send via e-mail
  • Keep everything else default (empty)

This results in an invalid post (HTTP 500) to create the transfer

{
    "from": null,
    "encryption": false,
    "encryption_key_version": "3",
    "encryption_password_encoding": "none",
    "encryption_password_version": 1,
    "encryption_password_hash_iterations": "4096000",
    "encryption_client_entropy": "",
    "files": [
        {
            "name": "GuestManual.pdf",
            "size": 1943472,
            "mime_type": "application/pdf",
            "cid": "file_1771418924065_15_1943472_515605",
            "aead": ""
        }
    ],
    "recipients": [],
    "subject": "",
    "message": "",
    "lang": "nl",
    "expires": 1772578800,
    "aup_checked": false,
    "options": {
        "get_a_link": false,
        "email_upload_complete": false,
        "disable_terasender": false,
        "email_me_copies": false,
        "email_me_on_expire": false,
        "email_download_complete": true,
        "email_daily_statistics": false,
        "email_report_on_closing": false,
        "enable_recipient_email_download_complete": false,
        "redirect_url_on_complete": "",
        "add_me_to_recipients": false
    }
}

Also, there apparently is no error handling for this case, so the upload page stalls and there is no way for the user to restart/resume/make changes anymore.

Suggested changes:

  • When "Send an email" is the communication method, enforce recipient information
  • Handle errors when trying to create a transfer

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions