Conversation
c64dfde to
9b7258d
Compare
marten-seemann
commented
Apr 14, 2023
| fmt.Println("AutoNAT status: ", i.Reachability.String()) | ||
| if i.PublicAddr != "" { | ||
| fmt.Println("Public address: ", i.PublicAddr) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I removed this log (?) output. It was misleading to begin with, a libp2p node doesn't only have a single public address. The correct way to obtain the addresses is to use the Addrs method on the host.
|
|
||
| var maddr string | ||
| if autonat.Status() == network.ReachabilityPublic { | ||
| pa, err := autonat.PublicAddr() |
Contributor
Author
There was a problem hiding this comment.
We removed the PublicAddr method from AutoNAT.
9b7258d to
fc812e3
Compare
magik6k
reviewed
Apr 20, 2023
|
|
||
| type NatInfo struct { | ||
| Reachability network.Reachability | ||
| PublicAddr string |
Contributor
There was a problem hiding this comment.
Can we change this to an array, and populate this from Addrs? We have a bunch of tools / docs which want this API / CLI (mostly there some docs that refer to the Public address output from cli)
28 tasks
Contributor
|
What's the state of this? I was hoping to get go-fil-markets updated but it needs this update for libp2p. |
This was referenced May 4, 2023
5 tasks
8 tasks
7b611ea to
85e76f9
Compare
magik6k
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps