feat: add upgrades.json file as canonical source of upgrade info#184
Merged
Conversation
BigLep
approved these changes
Oct 24, 2024
BigLep
left a comment
Member
There was a problem hiding this comment.
@rvagg : this is awesome. I don't see any downsides with this. Assuming @rjan90 is on board, we'll update the steps in https://docs.google.com/document/d/1KKJj2COb0vIqAQh-4F7fflJjxiTgGrU9oT9B461nsgg/edit#heading=h.xh3e4jwq08cp once this gets approved/merged.
2 tasks
Member
|
Seeing how the access to this repo is outdated (screenshot below), and @rjan90 gave a thumbs up, and I think risks here are minimal, I'm going to merge this... |
Member
|
I also updated the network upgrade template to account for this: https://docs.google.com/document/d/1KKJj2COb0vIqAQh-4F7fflJjxiTgGrU9oT9B461nsgg/edit#heading=h.8csw9xq9zwiy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

upgrades.jsonto the root of the repo with all of the upgrade information in it, including epochs, dates and actors CIDs for mainnet and calibrationnet. This can be consumed programatically and be used tasks such as informing users that upgrades are pending. Suggested by @magik6k._upgrades.jsexecutable in theNetwork Upgradesdirectory that will generate the README.md in that directory from the upgrades.json data.In the process a few minor inconsistencies were fixed up, including one FIP reference that pointed to a pull request.
Compare rendered versions side by side for accuracy:
As per docs inside
_upgrades.js, here's some quirks about the data that may be relevant to consumers:In addition, an upgrade with an actors version >8 without actors CIDs means that it hasn't been tagged.
/cc @rjan90 @BigLep