Skip to content

feat: introduce http api version#972

Merged
dirkmc merged 1 commit intomainfrom
feat/http-version
Nov 22, 2022
Merged

feat: introduce http api version#972
dirkmc merged 1 commit intomainfrom
feat/http-version

Conversation

@LexLuthr
Copy link
Copy Markdown
Collaborator

@LexLuthr LexLuthr commented Nov 21, 2022

Fixes #966

@LexLuthr LexLuthr requested a review from jacobheun November 21, 2022 12:41
Copy link
Copy Markdown
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks correct. Will leave to @dirkmc or @nonsense to review the code.

Ideally we should version 0.2.0 with the changes to '/piece'. As long as that lands before this goes out in a 1.5.1 RC leaving as 0.2.0 wfm.

@LexLuthr LexLuthr requested a review from dirkmc November 21, 2022 13:03
@LexLuthr
Copy link
Copy Markdown
Collaborator Author

I am working on the /piece endpoint now. It will land soon.

Copy link
Copy Markdown
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, test is concise and covers all new functionality, love it 🙌

@dirkmc dirkmc merged commit 313d0d2 into main Nov 22, 2022
@dirkmc dirkmc deleted the feat/http-version branch November 22, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an info endpoint to booster-http

3 participants