Conversation
|
|
||
| ## Running Boost devnet in Docker | ||
|
|
||
| ### Building Docker images |
There was a problem hiding this comment.
In the future, I would suggest pushing images to dockerhub and skipping this step for new users to start quickly without the building step.
And now I would suggest just cd docker && make build/all. Because if a user changes versions for the build step then versions need to be changed also in docker compose .env.
I was writing building instructions for the advanced boost developer who wants to push images
There was a problem hiding this comment.
In the future, I would suggest pushing images to dockerhub and skipping this step for new users to start quickly without the building step.
Agree, but I am not sure we should document the pushing here really... Pushing of images is going to happen within the team, by whoever has access to the Docker Registry.
We should make sure we have support to build Boost from source, because most developers on the team would be running a dev version of the Boost image, and sometimes even of Lotus images.
This PR is consolidating all README.md files in Boost into one main README.md
I've also removed some instructions that are duplicates across the various README.md
I've also moved
/build/devnetinto/docker/devnetas I don't think these Dockerfiles belong to/build.