Closed
Conversation
masih
reviewed
Mar 29, 2022
Member
masih
left a comment
There was a problem hiding this comment.
provider related changes look fine to me 👍
indexprovider/wrapper.go
Outdated
| PieceCID: pds.ClientDealProposal.Proposal.PieceCID, | ||
| FastRetrieval: true, | ||
| VerifiedDeal: pds.ClientDealProposal.Proposal.VerifiedDeal, | ||
| }) |
Member
There was a problem hiding this comment.
Consider:
-
either appending
metadata.Bitswap{}to a slice of protocols ifpds.ClientDealProposal.Proposal.VerifiedDealistruethen construct the metadata out of theifstatement, or -
move construction of
metadata.GraphsyncFilecoinV1out of if statement then conditionally construct metadata
to reduce duplicate code here?
This was referenced Apr 13, 2022
This was referenced Aug 17, 2022
Contributor
|
Closing this in favor of #707 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.