-
Notifications
You must be signed in to change notification settings - Fork 76
Consolidate Makefiles #779
Copy link
Copy link
Closed
Description
It'd be nice if we consolidate our Makefiles into one main Makefile at the root of Boost project.
At the moment we have 3 levels of Makefiles:
- boost/Makefile
- boost/docker/devnet/Makefile
- boost/docker/devnet/**/Makefile
While I think that having the build process of our docker stack in the Makefile, I am not sure we need the following targets:
-
docker push-- this is just an indirection on top of docker push. Furthermore 99% of developers won't ever need that target as they don't have access to push images, usually this is done by CI -
start-- indirection on top ofdocker compose-- I think it is fair to say that one needs to know the basics of docker compose and docker in general in order to use productively the devnet stack. -
clean-- all clean commands are indirection and won't fully clean all artefacts -
scan
I suggest we keep only the build targets and flatten all the Makefiles within the root Makefile, so that we don't have developers read and review multiple Makefiles when in reality we run just a few docker commands.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done