fix: download path encoding file paths #5655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
approved these changes
Jan 3, 2026
Member
hacdias
left a comment
There was a problem hiding this comment.
Thanks. I'm not sure why we were double encoding them, but it doesn't seem to make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in download function we are encoding file paths and double encoding files query params value.
Apache HTTP server by default doesn't allow encoded slashes in path and throws 404 error. Nginx by default sends the request to server.
this PR fixes the encoding so the filebrowser works seamlessly with Apache HTTP server and Nginx server without any manual configuration.
Additional Information
I have tested this change locally with NGINX and Apache server
closes #5651
Checklist
Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
masterbranch.