Skip to content

fix: added column separator select (comma, semicolon and both) in CSV viewer #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hacdias merged 2 commits into from
Dec 6, 2025
Merged

fix: added column separator select (comma, semicolon and both) in CSV viewer #5604

hacdias merged 2 commits into from
Dec 6, 2025

Conversation

@ArielLeyva
Copy link
Contributor

@ArielLeyva ArielLeyva commented Dec 6, 2025 •
edited
Loading

Description

  1. Added column separator selector in CSV viewer (comma, semicolon, auto).
  2. Updated CSV parsing function to accept a delimiter parameter (previously hardcoded to comma).
  3. Improved compatibility with CSV files using semicolon separators.

Additional Information

Closes #5594
Captura de pantalla

Checklist

Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • I am aware the project is currently in maintenance-only mode. See README
  • I am aware that translations MUST be made through Transifex and that this PR is NOT a translation update
  • I am making a PR against the master branch.
  • I am sure File Browser can be successfully built. See builds and development.

@ArielLeyva ArielLeyva requested a review from a team as a code owner December 6, 2025 01:54
@hacdias hacdias merged commit 204a3f0 into filebrowser:master Dec 6, 2025
6 checks passed
@ArielLeyva ArielLeyva deleted the fix/5594-column-separator-selector-in-csv-viewer branch December 6, 2025 12:21
@Nmrawe
Copy link

Nmrawe commented Dec 6, 2025

It seems that the label "Column Separator" is hard-coded in English.

@hacdias
Copy link
Member

hacdias commented Dec 6, 2025

@Nmrawe no, it's not. English is the fallback language. Here's how to contribute translations: https://filebrowser.org/contributing.html#translations

@Nmrawe
Copy link

Nmrawe commented Dec 6, 2025

@hacdias But there's no "Column Separator" in i18n JSON files. Only 3 separator options.

@hacdias
Copy link
Member

hacdias commented Dec 7, 2025

@Nmrawe ah, you're right, sorry. I'll fix that.

@Nmrawe
Copy link

Nmrawe commented Dec 7, 2025

@hacdias BTW, in filebrowser/frontend/src/views/files/Editor.vue, tooltips :label="t('buttons.increaseFontSize')" and :label="t('buttons.decreaseFontSize')" have no English text strings (missing from i18n JSON files as well).

@azdfzshffg
Copy link

azdfzshffg commented Dec 10, 2025

@hacdias / @ArielLeyva It works, however when displaying a fairly large file (but under 5 MB), you have to scroll a lot to find the separator at the bottom. Wouldn’t it be better to place it at the top in the selection toolbar?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hacdias hacdias hacdias approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: CSV Viewer does not automatically support Semicolon (;) as a delimiter

4 participants

@ArielLeyva @Nmrawe @hacdias @azdfzshffg