Skip to content

feat: add "copy inline link to clipboard" button to Share prompt #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hacdias merged 6 commits into from
Nov 22, 2025
Merged

feat: add "copy inline link to clipboard" button to Share prompt #5173

hacdias merged 6 commits into from
Nov 22, 2025

Conversation

@kosmosac
Copy link
Contributor

@kosmosac kosmosac commented Jun 21, 2025

Description

Whenever a user wanted to share a file for his own use (e.g. to embed it in a forum post), they had to go through the download page to get the inline link or edit the link manually. This adds a 3rd button in the share prompt instead.

Additional Information

Might not be the ideal way to do this though. The "open file" link on the download page is shorter but my knowledge of JS and GO is still too limited to implement that.

Checklist

Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • I am aware the project is currently in maintenance-only mode. See README
  • I am aware that translations MUST be made through Transifex and that this PR is NOT a translation update
  • I am making a PR against the master branch.
  • I am sure File Browser can be successfully built. See builds and development.

@kosmosac kosmosac requested review from hacdias and o1egl as code owners June 21, 2025 04:22
@hacdias hacdias removed the request for review from o1egl November 14, 2025 16:42
@hacdias
Copy link
Member

hacdias commented Nov 14, 2025

Hey! I think this can be a good idea, but I want to keep #5239 in mind. As such, if you are still interested in adding this option, please update the PR and I will look at it.

@hacdias hacdias changed the title feat: Add a "copy inline link to clipboard" button to the Share prompt feat: add a "copy inline link to clipboard" button to the Share prompt Nov 14, 2025
@hacdias hacdias changed the title feat: add a "copy inline link to clipboard" button to the Share prompt feat: add "copy inline link to clipboard" button to Share prompt Nov 14, 2025
@kosmosac kosmosac closed this Nov 17, 2025
@kosmosac kosmosac force-pushed the feature/share-inline-link branch from f442184 to f89435c Compare November 17, 2025 03:26
@kosmosac kosmosac reopened this Nov 17, 2025
@kosmosac kosmosac requested a review from a team as a code owner November 17, 2025 05:16
@kosmosac
Copy link
Contributor Author

kosmosac commented Nov 17, 2025 •
edited
Loading

Hey! I think this can be a good idea, but I want to keep #5239 in mind. As such, if you are still interested in adding this option, please update the PR and I will look at it.

I have reimplemented my proposal, this time even with the "short" link format I originally intended.
In my testing accessing the inline link for a password protected file ( #5239 ) ends up in a 401 Unauthorized.

hacdias
hacdias reviewed Nov 19, 2025
View reviewed changes
hacdias
hacdias approved these changes Nov 22, 2025
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I updated the PR to reuse a string we already had (Copy download link), updated the icon and made the button disabled for password-protected shares. I will merge!

Image

@hacdias hacdias merged commit d48f566 into filebrowser:master Nov 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hacdias hacdias hacdias approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kosmosac @hacdias