-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Description
Is your feature request related to a problem? Please describe.
I am no security expert but there have been several security issues with this feature. For Instance #3864 #3646 #3638 , but also on Reddit multiple people reported problems with this feature: see this and comments of this, just to cite a couple. As you can see, sometimes it's also due to misconfigurations, but this shows how easily this "delicate" feature can become a problem. On top of this I can also say that I just don't like it, but this is a personal opinion and I don't expect anyone to listen to me just because I consider it not secure by definition.
Describe the solution you'd like
I understand that asking for its removal could be too much and probably some folks also use it and consider it useful, so I'd like to suggest a boolean envornoment variable for the compose to turn it off (or if keeping the current logic "turn on the flag to disable the feature", so one can choose. It's also probably better to set the default value of the flag in order to keep the feature disabled until a person explicitly decide to enable it.
Describe alternatives you've considered
I know that it can be turned off with filebrowser config set --disable-exec=true as suggested by d-Rickyy-b in #3638 , but my current workaround to be sure it is immediately disabled after container creation is to modify the entrypoint as:
entrypoint: ["sh","-c","/filebrowser config set --disable-exec=true && /filebrowser"]Additional context
I am not a programmer, so I don't dare to mess with the code. But if u want I could raise a PR to add this simple variable to the Dockerfile, even if I think that there are far more elegant and better alternatives...