This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Fix for bug where script might not be called#181
Merged
scottjehl merged 1 commit intofilamentgroup:masterfrom Dec 19, 2016
Merged
Fix for bug where script might not be called#181scottjehl merged 1 commit intofilamentgroup:masterfrom
scottjehl merged 1 commit intofilamentgroup:masterfrom
Conversation
Firefox and IE/Edge won't load links that appear after the polyfill. What I think has been happening is the w.load event fires and clears the "run" interval before it has a chance to load styles that occur in between the last interval. This addition calls the rp.poly function one last time to make sure it catches any that occur within that interval gap. Original demo with link after polyfill (non-working in Firefox, IE, Edge): http://s.codepen.io/fatjester/debug/gMMrxv Modified version with link after polyfill (is working in Firefox, IE, Edge): http://s.codepen.io/fatjester/debug/gMMrxv filamentgroup#180
Member
|
Huh, interesting! Thanks. This does sound promising. I'll take a look. |
|
@scottjehl Any news on this PR? |
Member
|
This makes sense as a catchall for sure. thanks for the reminder. Merging |
|
@scottjehl Can this merge be tagged? |
|
Anyone? |
Member
|
tagged here and on npm. thanks for the followup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox and IE/Edge won't load links that appear after the polyfill.
What I think has been happening is the w.load event fires and clears the "run" interval before it has a chance to load styles that occur in between the last interval.
This addition calls the rp.poly function one last time to make sure it catches any that occur within that interval gap.
Original demo with link after polyfill (non-working in Firefox, IE, Edge):
http://s.codepen.io/fatjester/debug/gMMrxv
Modified version with link after polyfill (is working in Firefox, IE, Edge):
http://s.codepen.io/fatjester/debug/gMMrxv
#180