improve reading of DICOM coordinate information#1869
Merged
robertoostenveld merged 1 commit intofieldtrip:masterfrom Sep 2, 2021
Merged
improve reading of DICOM coordinate information#1869robertoostenveld merged 1 commit intofieldtrip:masterfrom
robertoostenveld merged 1 commit intofieldtrip:masterfrom
Conversation
Fhis improves the dicom_old implementation, which now has a full implementation of the mri.transform matrix (including translations and rotations) according to https://doi.org/10.1016/j.jneumeth.2016.03.001. Furthermore, the 1st and 2nd dimension of the output 3D volume is flipped to get the representation of DICOM rows and columns consistent with MATLAB.
Member
Author
|
this PR also includes some updates to the help of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the
dicom_oldimplementation, which now has a full implementation of themri.transformmatrix (including translations and rotations) according to https://doi.org/10.1016/j.jneumeth.2016.03.001.Furthermore, the 1st and 2nd dimension of the output 3D volume is flipped to get the representation of DICOM rows and columns consistent with MATLAB.