Skip to content

Fixed JRE runtime path#94

Merged
sergkh merged 1 commit intomasterfrom
launch4j-path-fix
Apr 18, 2023
Merged

Fixed JRE runtime path#94
sergkh merged 1 commit intomasterfrom
launch4j-path-fix

Conversation

@sergkh
Copy link
Copy Markdown
Member

@sergkh sergkh commented Apr 18, 2023

As corrected by @martinpaljak this setting is a runtime path on the client side, not the one used during build. So setting it to defaults that older version of the launch4j was providing.


@sergkh sergkh marked this pull request as ready for review April 18, 2023 09:56
@sergkh sergkh requested a review from martinpaljak as a code owner April 18, 2023 09:56
Copy link
Copy Markdown
Contributor

@luisrodero-fidesmo luisrodero-fidesmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergkh sergkh merged commit 9485b1b into master Apr 18, 2023
@sergkh sergkh deleted the launch4j-path-fix branch April 18, 2023 10:01
@sergkh sergkh changed the title Fijex JRE runtime path Fixes JRE runtime path Apr 18, 2023
@sergkh sergkh changed the title Fixes JRE runtime path Fixed JRE runtime path Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants