Limit to 1 regex application while checking basic auth.#84
Merged
jjluczyn-fidesmo merged 1 commit intomasterfrom Sep 8, 2022
Merged
Limit to 1 regex application while checking basic auth.#84jjluczyn-fidesmo merged 1 commit intomasterfrom
jjluczyn-fidesmo merged 1 commit intomasterfrom
Conversation
Member
|
facepalm moment! |
martinpaljak
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a password contains the character ":" right now we return an exception, according to the Basic Auth Scheme it should be allowed in password and not in username. Since we receive the auth string as a whole we have no way of knowing if many colons are intended or not.
We can simply assume the string is valid and limit the split to 1 parition (.split() command limit parameter refers to the max number of resulting elements).