Conversation
sergkh
reviewed
Mar 11, 2022
| @@ -262,7 +262,7 @@ public static void main(String[] argv) { | |||
| Card card = terminal.connect("*"); | |||
| Optional<byte[]> uid = getUID(card.getBasicChannel()); | |||
Member
There was a problem hiding this comment.
As I see this UID is only used for batching URL, so I would rather move it to the FidesmoCard (and reading as well). That will be more convenient to use and won't break encapsulation.
Member
Author
There was a problem hiding this comment.
I did it that way but then I decided to change and reuse that getUID command as it's the very first command that needs to be sent (previous to any other SELECT). Let me check if the probe could go after any other APDU exchange (which shouldn't) and it that case I'll move UID back to FidesmoCard
3ac9847 to
6b377d8
Compare
sergkh
approved these changes
Mar 11, 2022
…when running an explicit one that doesn't match the rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UID is required for checking to which concrete UID-range belongs some batch that will be assigned to the device