Skip to content

Fixed OS type version parsing#74

Merged
sergkh merged 2 commits intomasterfrom
os-version-fix
Jan 24, 2022
Merged

Fixed OS type version parsing#74
sergkh merged 2 commits intomasterfrom
os-version-fix

Conversation

@sergkh
Copy link
Copy Markdown
Member

@sergkh sergkh commented Jan 24, 2022

OS version field is an optional field so we need to expect that it might be absent. Also moved to a new osTypeVersionName field name.

@sergkh sergkh requested a review from martinpaljak as a code owner January 24, 2022 11:04
@sergkh sergkh requested review from luisrodero-fidesmo and removed request for martinpaljak January 24, 2022 11:04
Copy link
Copy Markdown
Contributor

@luisrodero-fidesmo luisrodero-fidesmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sergkh sergkh merged commit 422f57e into master Jan 24, 2022
@sergkh sergkh deleted the os-version-fix branch January 24, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants