fix: use diagnostic level to choose printing as error/info (#501)

psaintjust · web-flow · commit 7d10dac81ee5 · 2025-05-04T08:13:46.000+01:00
diff --git a/packages/vite-plugin-checker/src/checkers/biome/main.ts b/packages/vite-plugin-checker/src/checkers/biome/main.ts
@@ -7,6 +7,7 @@ import { FileDiagnosticManager } from '../../FileDiagnosticManager.js'
 import {
   composeCheckerSummary,
   consoleLog,
+  diagnosticToConsoleLevel,
   diagnosticToRuntimeError,
   diagnosticToTerminalLog,
   filterLogLevel,
@@ -58,7 +59,10 @@ const createDiagnostic: CreateDiagnostic<'biome'> = (pluginConfig) => {
 
         if (terminal) {
           for (const d of diagnostics) {
-            consoleLog(diagnosticToTerminalLog(d, 'Biome'), 'info')
+            consoleLog(
+              diagnosticToTerminalLog(d, 'Biome'),
+              diagnosticToConsoleLevel(d),
+            )
           }
 
           const errorCount = diagnostics.filter(
diff --git a/packages/vite-plugin-checker/src/checkers/eslint/main.ts b/packages/vite-plugin-checker/src/checkers/eslint/main.ts
@@ -12,6 +12,7 @@ import { createIgnore } from '../../glob.js'
 import {
   composeCheckerSummary,
   consoleLog,
+  diagnosticToConsoleLevel,
   diagnosticToRuntimeError,
   diagnosticToTerminalLog,
   filterLogLevel,
@@ -88,10 +89,12 @@ const createDiagnostic: CreateDiagnostic<'eslint'> = (pluginConfig) => {
 
       const dispatchDiagnostics = () => {
         const diagnostics = filterLogLevel(manager.getDiagnostics(), logLevel)
-
         if (terminal) {
           for (const d of diagnostics) {
-            consoleLog(diagnosticToTerminalLog(d, 'ESLint'), 'info')
+            consoleLog(
+              diagnosticToTerminalLog(d, 'ESLint'),
+              diagnosticToConsoleLevel(d),
+            )
           }
 
           const errorCount = diagnostics.filter(
diff --git a/packages/vite-plugin-checker/src/checkers/stylelint/main.ts b/packages/vite-plugin-checker/src/checkers/stylelint/main.ts
@@ -11,6 +11,7 @@ import { createIgnore } from '../../glob.js'
 import {
   composeCheckerSummary,
   consoleLog,
+  diagnosticToConsoleLevel,
   diagnosticToRuntimeError,
   diagnosticToTerminalLog,
   filterLogLevel,
@@ -63,7 +64,10 @@ const createDiagnostic: CreateDiagnostic<'stylelint'> = (pluginConfig) => {
 
         if (terminal) {
           for (const d of diagnostics) {
-            consoleLog(diagnosticToTerminalLog(d, 'Stylelint'), 'info')
+            consoleLog(
+              diagnosticToTerminalLog(d, 'Stylelint'),
+              diagnosticToConsoleLevel(d),
+            )
           }
 
           const errorCount = diagnostics.filter(
diff --git a/packages/vite-plugin-checker/src/checkers/vls/main.ts b/packages/vite-plugin-checker/src/checkers/vls/main.ts
@@ -1,11 +1,11 @@
-import os from 'node:os'
 import { fileURLToPath } from 'node:url'
 import { parentPort } from 'node:worker_threads'
 
 import { Checker } from '../../Checker.js'
 import {
   composeCheckerSummary,
   consoleLog,
+  diagnosticToConsoleLevel,
   diagnosticToRuntimeError,
   diagnosticToTerminalLog,
   toClientPayload,
@@ -57,12 +57,12 @@ export const createDiagnostic: CreateDiagnostic<'vls'> = (pluginConfig) => {
           }
 
           if (terminal) {
-            consoleLog(
-              normalized
-                .map((d) => diagnosticToTerminalLog(d, 'VLS'))
-                .join(os.EOL),
-              'info',
-            )
+            for (const d of normalized) {
+              consoleLog(
+                diagnosticToTerminalLog(d, 'VLS'),
+                diagnosticToConsoleLevel(d),
+              )
+            }
           }
         }
 
diff --git a/packages/vite-plugin-checker/src/logger.ts b/packages/vite-plugin-checker/src/logger.ts
@@ -128,6 +128,14 @@ export function diagnosticToTerminalLog(
     .join(os.EOL)
 }
 
+export function diagnosticToConsoleLevel(d: NormalizedDiagnostic) {
+  if (!d) return 'error'
+  if (d.level === DiagnosticLevel.Message) return 'info'
+  if (d.level === DiagnosticLevel.Suggestion) return 'info'
+  if (d.level === DiagnosticLevel.Warning) return 'warn'
+  return 'error'
+}
+
 export function diagnosticToRuntimeError(
   d: NormalizedDiagnostic,
 ): DiagnosticToRuntime
