fix: do not use error level for info/warn messages (#474)

danielroe · web-flow · commit 694b740fb50e · 2025-03-17T15:04:32.000Z
diff --git a/packages/vite-plugin-checker/src/checkers/biome/main.ts b/packages/vite-plugin-checker/src/checkers/biome/main.ts
@@ -58,7 +58,7 @@ const createDiagnostic: CreateDiagnostic<'biome'> = (pluginConfig) => {
 
         if (terminal) {
           for (const d of diagnostics) {
-            consoleLog(diagnosticToTerminalLog(d, 'Biome'))
+            consoleLog(diagnosticToTerminalLog(d, 'Biome'), 'info')
           }
 
           const errorCount = diagnostics.filter(
@@ -67,7 +67,10 @@ const createDiagnostic: CreateDiagnostic<'biome'> = (pluginConfig) => {
           const warningCount = diagnostics.filter(
             (d) => d.level === DiagnosticLevel.Warning,
           ).length
-          consoleLog(composeCheckerSummary('Biome', errorCount, warningCount))
+          consoleLog(
+            composeCheckerSummary('Biome', errorCount, warningCount),
+            errorCount ? 'error' : warningCount ? 'warn' : 'info',
+          )
         }
 
         if (overlay) {
diff --git a/packages/vite-plugin-checker/src/checkers/eslint/main.ts b/packages/vite-plugin-checker/src/checkers/eslint/main.ts
@@ -91,7 +91,7 @@ const createDiagnostic: CreateDiagnostic<'eslint'> = (pluginConfig) => {
 
         if (terminal) {
           for (const d of diagnostics) {
-            consoleLog(diagnosticToTerminalLog(d, 'ESLint'))
+            consoleLog(diagnosticToTerminalLog(d, 'ESLint'), 'info')
           }
 
           const errorCount = diagnostics.filter(
@@ -100,7 +100,10 @@ const createDiagnostic: CreateDiagnostic<'eslint'> = (pluginConfig) => {
           const warningCount = diagnostics.filter(
             (d) => d.level === DiagnosticLevel.Warning,
           ).length
-          consoleLog(composeCheckerSummary('ESLint', errorCount, warningCount))
+          consoleLog(
+            composeCheckerSummary('ESLint', errorCount, warningCount),
+            errorCount ? 'error' : warningCount ? 'warn' : 'info',
+          )
         }
 
         if (overlay) {
diff --git a/packages/vite-plugin-checker/src/checkers/stylelint/main.ts b/packages/vite-plugin-checker/src/checkers/stylelint/main.ts
@@ -63,7 +63,7 @@ const createDiagnostic: CreateDiagnostic<'stylelint'> = (pluginConfig) => {
 
         if (terminal) {
           for (const d of diagnostics) {
-            consoleLog(diagnosticToTerminalLog(d, 'Stylelint'))
+            consoleLog(diagnosticToTerminalLog(d, 'Stylelint'), 'info')
           }
 
           const errorCount = diagnostics.filter(
@@ -74,6 +74,7 @@ const createDiagnostic: CreateDiagnostic<'stylelint'> = (pluginConfig) => {
           ).length
           consoleLog(
             composeCheckerSummary('Stylelint', errorCount, warningCount),
+            errorCount ? 'error' : warningCount ? 'warn' : 'info',
           )
         }
 
diff --git a/packages/vite-plugin-checker/src/checkers/typescript/main.ts b/packages/vite-plugin-checker/src/checkers/typescript/main.ts
@@ -124,6 +124,7 @@ const createDiagnostic: CreateDiagnostic<'typescript'> = (pluginConfig) => {
                     diagnostic.messageText.toString(),
                   ),
               ),
+              errorCount ? 'error' : 'info',
             )
           }
         })
diff --git a/packages/vite-plugin-checker/src/checkers/vls/main.ts b/packages/vite-plugin-checker/src/checkers/vls/main.ts
@@ -38,7 +38,10 @@ export const createDiagnostic: CreateDiagnostic<'vls'> = (pluginConfig) => {
         (errorCount, warningCount) => {
           if (!terminal) return
 
-          consoleLog(composeCheckerSummary('VLS', errorCount, warningCount))
+          consoleLog(
+            composeCheckerSummary('VLS', errorCount, warningCount),
+            errorCount ? 'error' : warningCount ? 'warn' : 'info',
+          )
         }
 
       const onDispatchDiagnostics: DiagnosticOptions['onDispatchDiagnostics'] =
@@ -58,6 +61,7 @@ export const createDiagnostic: CreateDiagnostic<'vls'> = (pluginConfig) => {
               normalized
                 .map((d) => diagnosticToTerminalLog(d, 'VLS'))
                 .join(os.EOL),
+              'info',
             )
           }
         }
diff --git a/packages/vite-plugin-checker/src/checkers/vueTsc/main.ts b/packages/vite-plugin-checker/src/checkers/vueTsc/main.ts
@@ -122,7 +122,7 @@ const createDiagnostic: CreateDiagnostic<'vueTsc'> = (pluginConfig) => {
 
             // TODO: only macOS will report multiple times for same result
             prevLogChunk = logChunk
-            consoleLog(logChunk)
+            consoleLog(logChunk, errorCount ? 'error' : 'info')
           }
         })
       }
diff --git a/packages/vite-plugin-checker/src/logger.ts b/packages/vite-plugin-checker/src/logger.ts
@@ -419,12 +419,13 @@ export function ensureCall(callback: CallableFunction) {
   })
 }
 
-export function consoleLog(value: string) {
+export function consoleLog(value: string, level: 'info' | 'warn' | 'error') {
   if (isMainThread) {
-    console.log(value)
+    console[level](value)
   } else {
     parentPort?.postMessage({
       type: ACTION_TYPES.console,
+      level: level,
       payload: value,
     })
   }
diff --git a/packages/vite-plugin-checker/src/main.ts b/packages/vite-plugin-checker/src/main.ts
@@ -201,7 +201,7 @@ export function checker(userConfig: UserPluginConfig): Plugin {
               // for test injection and customize logger in the future
               Checker.log(action)
             } else {
-              logger!.error(action.payload)
+              logger![action.level](action.payload)
             }
           }
         })
diff --git a/packages/vite-plugin-checker/src/types.ts b/packages/vite-plugin-checker/src/types.ts
@@ -260,6 +260,7 @@ export interface ConfigureServerAction extends AbstractAction {
 
 export interface ConsoleAction extends AbstractAction {
   type: ACTION_TYPES.console
+  level: 'info' | 'warn' | 'error'
   payload: string
 }
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ const createDiagnostic: CreateDiagnostic<'stylelint'> = (pluginConfig) => {`
`63`	`63`
`64`	`64`	`if (terminal) {`
`65`	`65`	`for (const d of diagnostics) {`
`66`		`- consoleLog(diagnosticToTerminalLog(d, 'Stylelint'))`
	`66`	`+ consoleLog(diagnosticToTerminalLog(d, 'Stylelint'), 'info')`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`const errorCount = diagnostics.filter(`
`@@ -74,6 +74,7 @@ const createDiagnostic: CreateDiagnostic<'stylelint'> = (pluginConfig) => {`
`74`	`74`	`).length`
`75`	`75`	`consoleLog(`
`76`	`76`	`composeCheckerSummary('Stylelint', errorCount, warningCount),`
	`77`	`+ errorCount ? 'error' : warningCount ? 'warn' : 'info',`
`77`	`78`	`)`
`78`	`79`	`}`
`79`	`80`
Original file line number	Diff line number	Diff line change
`@@ -124,6 +124,7 @@ const createDiagnostic: CreateDiagnostic<'typescript'> = (pluginConfig) => {`
`124`	`124`	`diagnostic.messageText.toString(),`
`125`	`125`	`),`
`126`	`126`	`),`
	`127`	`+ errorCount ? 'error' : 'info',`
`127`	`128`	`)`
`128`	`129`	`}`
`129`	`130`	`})`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,10 @@ export const createDiagnostic: CreateDiagnostic<'vls'> = (pluginConfig) => {`
`38`	`38`	`(errorCount, warningCount) => {`
`39`	`39`	`if (!terminal) return`
`40`	`40`
`41`		`- consoleLog(composeCheckerSummary('VLS', errorCount, warningCount))`
	`41`	`+ consoleLog(`
	`42`	`+ composeCheckerSummary('VLS', errorCount, warningCount),`
	`43`	`+ errorCount ? 'error' : warningCount ? 'warn' : 'info',`
	`44`	`+ )`
`42`	`45`	`}`
`43`	`46`
`44`	`47`	`const onDispatchDiagnostics: DiagnosticOptions['onDispatchDiagnostics'] =`
`@@ -58,6 +61,7 @@ export const createDiagnostic: CreateDiagnostic<'vls'> = (pluginConfig) => {`
`58`	`61`	`normalized`
`59`	`62`	`.map((d) => diagnosticToTerminalLog(d, 'VLS'))`
`60`	`63`	`.join(os.EOL),`
	`64`	`+ 'info',`
`61`	`65`	`)`
`62`	`66`	`}`
`63`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ const createDiagnostic: CreateDiagnostic<'vueTsc'> = (pluginConfig) => {`
`122`	`122`
`123`	`123`	`// TODO: only macOS will report multiple times for same result`
`124`	`124`	`prevLogChunk = logChunk`
`125`		`- consoleLog(logChunk)`
	`125`	`+ consoleLog(logChunk, errorCount ? 'error' : 'info')`
`126`	`126`	`}`
`127`	`127`	`})`
`128`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ export function checker(userConfig: UserPluginConfig): Plugin {`
`201`	`201`	`// for test injection and customize logger in the future`
`202`	`202`	`Checker.log(action)`
`203`	`203`	`} else {`
`204`		`- logger!.error(action.payload)`
	`204`	`+ logger![action.level](action.payload)`
`205`	`205`	`}`
`206`	`206`	`}`
`207`	`207`	`})`
Original file line number	Diff line number	Diff line change
`@@ -260,6 +260,7 @@ export interface ConfigureServerAction extends AbstractAction {`
`260`	`260`
`261`	`261`	`export interface ConsoleAction extends AbstractAction {`
`262`	`262`	`type: ACTION_TYPES.console`
	`263`	`+ level: 'info' \| 'warn' \| 'error'`
`263`	`264`	`payload: string`
`264`	`265`	`}`
`265`	`266`