I was considering deprecating the Object class but I'm not sure this would really help anybody. People who want to use PHP 7.2 will always have to update their code to use the ASNObject and update all Object imports, fromBinary(…) calls and inheriting classes. If there was more development in PHPASN1 (e.g. new features being developed) it would have warranted such an approach but I think this library has been quite stable over the last years and I have no plans to add new features. Thus I would just create a new major release for the sake of PHP 7.2 compatibility and be done with it.

I agree that the new release seems like a great opportunity to finally drop PHP 5.6 since everybody who wants to upgrade would do this only to get the PHP 7.2 support. I would also take pull requests for adding the remaining three objects to the library, but I don't think this should be a blocker for releasing the new version because this can be added via a normal minor release (e.g. v2.1.0).

With the type hints I guess you mean the new scalar type hints that came with PHP 7? I didn't really follow up on the new features there but now could be a good time to get those into the library. However I'm not sure this would add a lot of value and I honestly don't want to spend time on PHPASN1 at the moment except to fix bugs. Do you think it would be a break in backwards compatibility to add type hints later (maybe via a PR)? If the caller passes in the wrong type this should already lead to an Exception or maybe undefined behavior. Adding a type hint in that sense could be considered a feature but I'm not sure about this approach.

Object is a special class name #65

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`Object` is a special class name #65