Skip to content

Adding season to ff league function#288

Merged
tanho63 merged 2 commits intoffverse:devfrom
joeflan:adding-season-to-ff_league-function
May 27, 2021
Merged

Adding season to ff league function#288
tanho63 merged 2 commits intoffverse:devfrom
joeflan:adding-season-to-ff_league-function

Conversation

@joeflan
Copy link
Copy Markdown
Contributor

@joeflan joeflan commented May 27, 2021

First time contributing to this project, let me know if I've messed anything up.

@tanho63 tanho63 changed the base branch from main to dev May 27, 2021 01:21
@tanho63 tanho63 self-requested a review May 27, 2021 01:23
Copy link
Copy Markdown
Member

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see note about ints

@tanho63 tanho63 linked an issue May 27, 2021 that may be closed by this pull request
@tanho63
Copy link
Copy Markdown
Member

tanho63 commented May 27, 2021

Looks great! Running automated checks now, then I will merge/bumpver/add entry to news. It'll sit in dev for a bit until a few more minor tweaks get added, then eventually I'll make one larger release that goes to CRAN!

@tanho63 tanho63 enabled auto-merge (squash) May 27, 2021 02:25
@joeflan
Copy link
Copy Markdown
Contributor Author

joeflan commented May 27, 2021

Looks great! Running automated checks now, then I will merge/bumpver/add entry to news. It'll sit in dev for a bit until a few more minor tweaks get added, then eventually I'll make one larger release that goes to CRAN!

Awesome. I know it's an easy one but I'm hoping I can get my feet wet with a couple of these first and then contribute a bit more.

@tanho63 tanho63 merged commit 92376b2 into ffverse:dev May 27, 2021
@joeflan joeflan deleted the adding-season-to-ff_league-function branch September 15, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ff_league should return the season as a column of the dataframe

2 participants