Merged
Conversation
sayurin
requested changes
Aug 16, 2022
Member
sayurin
left a comment
There was a problem hiding this comment.
PRありがとうございます。コードを一部改善してほしいかなと。
sayurin
requested changes
Aug 16, 2022
ftpproc.cpp
Outdated
| for (auto oit = Old.begin(), oend = Old.end(); rit != rend && oit != oend && *rit == *oit; ++rit, ++oit) | ||
|
|
||
| fs::path RemotePath = RemoteFile; | ||
| RemotePath.remove_filename(); |
Member
There was a problem hiding this comment.
auto const RemotePath = RemoteFile.parent_path() で済みますか？ OldPath の方も。この方法なら、変更を加えないのでconstも付けられますし。
Contributor
Author
There was a problem hiding this comment.
レビューありがとうございます。コード修正しました。
parent_path()を使用した方がコードがわかりやすいですね。動作も問題ありませんでした。
ftpproc.cpp
Outdated
| fs::path path; | ||
| auto rit = RemoteFile.begin(), rend = RemoteFile.end(); | ||
| for (auto oit = Old.begin(), oend = Old.end(); rit != rend && oit != oend && *rit == *oit; ++rit, ++oit) | ||
|
|
Closed
sayurin
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
引数のRemoteFile、Oldの最後尾要素にはファイル名が含まれているため、
指定したファイル名のディレクトリが作成されていました。
remove_filename()でファイル名を取り除き、ディレクトリが作成されないように修正しました。