Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
これまで
DoClose()およびSocketContext::Close()が存在していたが、呼び出しが不足すればsocket leak、複数回呼べばdouble-freeが発生する危うい実装であった。これらの処理を
SocketContextのデストラクタに移動することで、解放処理を確実に1回のみ実行する。また、
SocketContext::Close()ではソケット一覧を表すmapを管理していたが、解放タイミングをデストラクタに任せると問題が発生する。ソケット一覧が必要となる理由はWSAAsyncSelect()が使われているからであるが、これをWSAEventSelect()に移行する。WSAEventSelect()に移行したことにより、メッセージループ依存が解消され、ソケット用Windowも不要となる。