Skip to content

vp migrate beta test#1

Draft
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test
Draft

vp migrate beta test#1
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary

Describe the change and its scope.

Validation

  • vp check
  • vp test --run
  • vp run test:e2e when routing or user-visible flows changed

Docs And Contracts

  • README/docs updated if behavior or claims changed
  • env/config/runtime contracts kept in sync

Risks

List any known caveats, migrations, or follow-up work.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates and configures Vite+ as the unified toolchain for the project, updating documentation, VS Code settings, TypeScript configurations, and dependency locks to align with the new toolchain. Additionally, vite.config.ts has been updated to use lazyPlugins for plugin loading. Feedback on these changes suggests referencing the catalog version for vite-plus in pnpm-workspace.yaml to maintain a single source of truth, and removing the redundant source.fixAll.eslint action in .vscode/settings.json since ESLint is disabled.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pnpm-workspace.yaml
overrides:
vite: 'catalog:'
vitest: 'catalog:'
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@dca39038de6ca46e523bf64dc09bf100b636eea9

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain a single source of truth for dependency versions, reference the catalog version for vite-plus using 'catalog:' in the overrides block, consistent with how vite and vitest are configured.

  vite-plus: 'catalog:'

Comment thread .vscode/settings.json
Comment on lines +23 to +24
"source.fixAll.eslint": "explicit",
"source.fixAll.oxc": "explicit"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since ESLint is disabled (eslint.enable set to false) and not installed in the project, the source.fixAll.eslint action is redundant and can be removed.

    "source.fixAll.oxc": "explicit"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant