vp migrate beta test#8
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project to use vite-plus and catalog-based dependency management in pnpm. It updates test imports from vitest to vite-plus/test, adds pre-commit hooks, and configures a registry bridge. A critical issue was identified in pnpm-workspace.yaml where peerDependencyRules is incorrectly placed and should be moved to the root package.json under pnpm.peerDependencyRules to be recognized by pnpm.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| peerDependencyRules: | ||
| allowAny: | ||
| - vite | ||
| - vitest | ||
| allowedVersions: | ||
| vite: '*' | ||
| vitest: '*' |
There was a problem hiding this comment.
The peerDependencyRules configuration is not supported in pnpm-workspace.yaml. In pnpm, peer dependency rules must be defined in the root package.json under the pnpm.peerDependencyRules field. Placing them here will cause pnpm to ignore these rules, which may lead to unresolved peer dependency warnings or errors during installation. Please move this block to your root package.json.
No description provided.