chore: vp migrate beta test#1
Conversation
There was a problem hiding this comment.
Code Review
This pull request configures a custom registry bridge in .npmrc and updates dependency resolutions in package.json and pnpm-workspace.yaml to use a catalog-based setup pointing to a commit-based beta version of vite and vite-plus. The feedback highlights a conflict where package.json still overrides vite to version 0.2.1 instead of catalog:, and suggests simplifying the minimumReleaseAgeExclude list in pnpm-workspace.yaml by using glob patterns instead of listing each platform-specific package individually.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "typescript": "~6.0.3", | ||
| "vite": "npm:@voidzero-dev/vite-plus-core@^0.2.1", | ||
| "vite-plus": "^0.2.1" | ||
| "vite": "catalog:", |
There was a problem hiding this comment.
The overrides block in package.json (lines 24-26) still overrides vite to npm:@voidzero-dev/vite-plus-core@0.2.1. This directly conflicts with the new workspace-level overrides in pnpm-workspace.yaml which overrides vite to "catalog:" (resolving to the commit-based beta version 0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5). You should remove the overrides block from package.json to prevent resolution conflicts and ensure the correct beta version is used.
| - "@voidzero-dev/vite-plus-core@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5" | ||
| - "@voidzero-dev/vite-plus-darwin-arm64@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5" | ||
| - "@voidzero-dev/vite-plus-darwin-x64@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5" | ||
| - "@voidzero-dev/vite-plus-linux-arm64-gnu@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5" | ||
| - "@voidzero-dev/vite-plus-linux-arm64-musl@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5" | ||
| - "@voidzero-dev/vite-plus-linux-x64-gnu@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5" | ||
| - "@voidzero-dev/vite-plus-linux-x64-musl@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5" | ||
| - "@voidzero-dev/vite-plus-win32-arm64-msvc@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5" | ||
| - "@voidzero-dev/vite-plus-win32-x64-msvc@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5" | ||
| - vite-plus@0.0.0-commit.63f877e809ba7f246ada990e86d87b4330e37ec5 |
There was a problem hiding this comment.
Instead of listing every platform-specific package and pinning them to a specific commit-based version, you can use glob patterns and package names in minimumReleaseAgeExclude. This is much cleaner, less verbose, and avoids having to update this list every time a new beta/commit version is released.
- "@voidzero-dev/*"
- vite-plus
No description provided.