Skip to content

vp migrate last!#23

Draft
fengmk2 wants to merge 3 commits into
mainfrom
vp-migrate-test-v3
Draft

vp migrate last!#23
fengmk2 wants to merge 3 commits into
mainfrom
vp-migrate-test-v3

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jul 2, 2026

Copy link
Copy Markdown
Owner

No description provided.


- name: Setup Vite+
uses: voidzero-dev/setup-vp@2dec1e33f4ab2c6d5bce1b0c4607961bb1a3f7a1 # v1
uses: voidzero-dev/setup-vp@13e7afb99c66525824db54e107d667216e795d37 # v1

- name: Setup Vite+
uses: voidzero-dev/setup-vp@2dec1e33f4ab2c6d5bce1b0c4607961bb1a3f7a1 # v1
uses: voidzero-dev/setup-vp@13e7afb99c66525824db54e107d667216e795d37 # v1

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the repository to use vite-plus and vite-plus/test instead of standard vite and vitest. This involves updating configuration files, package dependencies, and test imports across numerous files, as well as configuring a new registry bridge in .npmrc and adding several packages to minimumReleaseAgeExclude in pnpm-workspace.yaml. The review feedback recommends removing the redundant @oxlint-tsgolint/* exclusion pattern from pnpm-workspace.yaml because no scoped packages exist under that scope.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pnpm-workspace.yaml
Comment on lines +147 to +148
- oxlint-tsgolint
- "@oxlint-tsgolint/*"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The package oxlint-tsgolint is published as an unscoped package on npm, and there are no scoped packages under the @oxlint-tsgolint scope. Therefore, the exclusion pattern "@oxlint-tsgolint/*" is redundant and can be safely removed.

  - oxlint-tsgolint

Comment thread package.json
"vitest": "catalog:"
},
"packageManager": "pnpm@11.1.1"
"packageManager": "pnpm@11.1.2"

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11.1.1 is a bug version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants