vp migrate v2#17
Conversation
There was a problem hiding this comment.
Code Review
This pull request configures a custom registry bridge in .npmrc, updates vite and vitest dependencies to use catalog-based versions across the workspace, and updates pnpm-workspace.yaml with commit-based versions and a list of excluded packages under minimumReleaseAgeExclude. Feedback suggests simplifying the minimumReleaseAgeExclude configuration in pnpm-workspace.yaml by using glob patterns and version-less package names to avoid hardcoding specific commit hashes and platform-specific package variants.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| minimumReleaseAgeExclude: | ||
| - "@voidzero-dev/vite-plus-core@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b" | ||
| - "@voidzero-dev/vite-plus-darwin-arm64@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b" | ||
| - "@voidzero-dev/vite-plus-darwin-x64@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b" | ||
| - "@voidzero-dev/vite-plus-linux-arm64-gnu@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b" | ||
| - "@voidzero-dev/vite-plus-linux-arm64-musl@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b" | ||
| - "@voidzero-dev/vite-plus-linux-x64-gnu@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b" | ||
| - "@voidzero-dev/vite-plus-linux-x64-musl@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b" | ||
| - "@voidzero-dev/vite-plus-win32-arm64-msvc@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b" | ||
| - "@voidzero-dev/vite-plus-win32-x64-msvc@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b" | ||
| - vite-plus@0.0.0-commit.d31f7b6818544e8261b9ccce2374a5e32a8b666f || 0.0.0-commit.fcd4a979bd79b8328dd3318e451fc135242c0e4b | ||
| - "@oxlint-tsgolint/darwin-arm64@0.24.0" | ||
| - "@oxlint-tsgolint/darwin-x64@0.24.0" | ||
| - "@oxlint-tsgolint/linux-arm64@0.24.0" | ||
| - "@oxlint-tsgolint/linux-x64@0.24.0" | ||
| - "@oxlint-tsgolint/win32-arm64@0.24.0" | ||
| - "@oxlint-tsgolint/win32-x64@0.24.0" | ||
| - oxlint-tsgolint@0.24.0 |
There was a problem hiding this comment.
Hardcoding specific commit hashes and listing every platform-specific package variant in minimumReleaseAgeExclude is highly fragile and will require manual updates on every new commit-based release.
pnpm supports package name patterns (globs) and version-less package exclusions under minimumReleaseAgeExclude. You can simplify this configuration and make it future-proof by using glob patterns for the scoped packages and version-less names for the individual packages.
minimumReleaseAgeExclude:
- "@voidzero-dev/*"
- "vite-plus"
- "@oxlint-tsgolint/*"
- "oxlint-tsgolint"213cbf1 to
c169bc6
Compare
c169bc6 to
29661a9
Compare
No description provided.