vp migrate beta test#16
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the project's workspace and dependency configurations to use pre-release builds of vite and vite-plus from pkg.pr.new, alongside updating oxfmt and oxlint versions. Additionally, it introduces lazy plugin loading in the dashboard's Vite configuration and adds blockExoticSubdeps: false to the workspace settings. Regarding feedback, a concern was raised about disabling pnpm's protection against phantom dependencies with blockExoticSubdeps: false; it is recommended to document this workaround and track its removal.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| allowedVersions: | ||
| vite: "*" | ||
| vitest: "*" | ||
| blockExoticSubdeps: false |
There was a problem hiding this comment.
Setting blockExoticSubdeps: false disables pnpm's protection against packages requiring dependencies that are not explicitly listed in their package.json. While this might be necessary as a temporary workaround for the beta version of vite-plus, it can hide potential dependency issues and make the dependency tree less predictable.
It would be beneficial to add a comment here explaining why this setting is currently needed. Also, consider creating a follow-up ticket to track the removal of this setting once the underlying dependency issues in the beta package are resolved.
References
- It is a best practice to maintain a strict and explicit dependency graph. Disabling checks like
blockExoticSubdepscan lead to 'phantom dependencies' and make builds less reliable and harder to debug. Such settings should be used sparingly and temporarily, with clear documentation on why they are needed.
No description provided.