chore: vp migrate v2#11
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the repository to use a specific commit version of vite (aliased to @voidzero-dev/vite-plus-core) and vite-plus across multiple packages, and configures .npmrc to use the vite-plus preview build registry bridge. In packages/varlet-cli/src/module.d.ts, the runCLI constant was modified to be exported. However, using export declare inside an ambient module declaration is redundant and causes a TypeScript compiler error (TS1038); it should be simplified to export const runCLI: any.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| declare module 'jest' { | ||
| declare const runCLI: any | ||
| export declare const runCLI: any |
There was a problem hiding this comment.
Using the declare modifier inside an ambient module declaration (declare module '...') is redundant and causes a TypeScript compiler error: TS1038: A 'declare' modifier cannot be used in an already ambient context.
To resolve this, remove the declare keyword and simply export the constant.
export const runCLI: any
@varlet/cli
@varlet/icons
@varlet/import-resolver
@varlet/preset-tailwindcss
@varlet/preset-unocss
@varlet/shared
@varlet/touch-emulator
@varlet/ui
@varlet/use
@varlet/vite-plugins
commit: |
fe21eef to
c40ba9f
Compare
c40ba9f to
7365899
Compare
858b0dc to
f213a24
Compare
Checklist
List of tasks you have already done and plan to do.
Change information
Describe your modifications here.
Issues
The issues you want to close, formatted as close #1.
Related Links
Links related to this pr.