chore: vp migrate v2#11
Conversation
Signed-off-by: MK <fengmk2@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request migrates the project and its example package to use vite-plus instead of standard vite, updating scripts, imports, and type references accordingly, and defining catalog versions in pnpm-workspace.yaml. The review feedback correctly identifies that vite-plus is missing from the devDependencies of the example package despite being used in its configuration and scripts, and suggests adding it to ensure proper dependency resolution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "tailwindcss": "^4.3.0", | ||
| "typescript": "^6.0.3", | ||
| "vite": "^8.0.13", | ||
| "vite": "catalog:", |
There was a problem hiding this comment.
The example package uses vp in its scripts, imports from vite-plus in vite.config.ts, and references vite-plus/client in vite-env.d.ts. However, vite-plus is not declared in its devDependencies.
Add vite-plus to devDependencies to ensure proper dependency resolution and avoid compilation or runtime errors.
| "vite": "catalog:", | |
| "vite": "catalog:", | |
| "vite-plus": "catalog:", |
No description provided.