vp migrate beta test#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project and its examples to use vite-plus and vp commands, updates dependency versions to use the pnpm workspace catalog, and moves onlyBuiltDependencies configuration to pnpm-workspace.yaml. Feedback is provided to improve dependency consistency by cataloging @vitest/ui and to remove an unnecessary *.vue type declaration file in the library's root source directory.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "@oxc-project/types": "^0.129.0", | ||
| "@types/node": "^25.6.0", | ||
| "@vitest/ui": "^4.1.5", | ||
| "@vitest/ui": "4.1.9", |
There was a problem hiding this comment.
To maintain version consistency and prevent potential runtime compatibility issues, consider adding @vitest/ui to the pnpm workspace catalog in pnpm-workspace.yaml (matching the vitest version) and referencing it here via catalog:.
| "@vitest/ui": "4.1.9", | |
| "@vitest/ui": "catalog:", |
| declare module '*.vue' { | ||
| import type { DefineComponent } from 'vue' | ||
| const component: DefineComponent<{}, {}, unknown> | ||
| export default component | ||
| } |
There was a problem hiding this comment.
The root src/ directory of this library (unplugin-turbo-console) only contains TypeScript files and does not contain or import any .vue files. Declaring the *.vue module here is unnecessary and could pollute the global type space for the library. Consider removing this file if it is not needed.
No description provided.