vp migrate beta test#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project to the Vite+ unified toolchain, updating dependencies, lockfiles, VS Code configurations, and test imports to use Vite+ instead of Vitest. Feedback on these changes highlights several issues: a temporary registry bridge URL was committed to .npmrc, a global VS Code formatter setting was configured redundantly and could affect non-JS/TS files, and vite-plus is missing from the devDependencies of the benchmark, examples, and core packages despite being actively used.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| # pkg.pr.new registry bridge (added by test-pkg-pr-new-migrate.sh) | ||
| registry=https://pkg-pr-registry-bridge.void.app/ |
There was a problem hiding this comment.
Committing a custom registry bridge URL (https://pkg-pr-registry-bridge.void.app/) to .npmrc is risky. As indicated by the comment, this was added by a test script (test-pkg-pr-new-migrate.sh). If this registry is temporary or private, it will break package installation for other developers and CI/CD pipelines. Please ensure this temporary configuration is removed before merging.
| ], | ||
| "editor.defaultFormatter": "oxc.oxc-vscode", | ||
| "[javascript]": { |
There was a problem hiding this comment.
Setting "editor.defaultFormatter": "oxc.oxc-vscode" globally can cause formatting issues or failures for non-JS/TS files (such as JSON, Markdown, or YAML) because Oxfmt only supports JavaScript and TypeScript. Since you have already specified language-specific formatters for [javascript], [javascriptreact], [typescript], and [typescriptreact], the global setting is redundant and should be removed.
],
"[javascript]": {| "devDependencies": { | ||
| "@types/node": "25.5.0" | ||
| "@types/node": "25.5.0", | ||
| "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.4fd595565e1b44be3b8218943e0ec5ae7d08889d" | ||
| }, |
There was a problem hiding this comment.
The package imports defineConfig from vite-plus in its vite.config.ts, but vite-plus is not declared in its devDependencies. To prevent phantom dependency issues and ensure reliable dependency resolution and task tracking in the monorepo, please add "vite-plus": "catalog:" to devDependencies.
| "devDependencies": { | |
| "@types/node": "25.5.0" | |
| "@types/node": "25.5.0", | |
| "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.4fd595565e1b44be3b8218943e0ec5ae7d08889d" | |
| }, | |
| "devDependencies": { | |
| "@types/node": "25.5.0", | |
| "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.4fd595565e1b44be3b8218943e0ec5ae7d08889d", | |
| "vite-plus": "catalog:" | |
| }, |
| "devDependencies": { | ||
| "@faker-js/faker": "10.4.0", | ||
| "@types/node": "25.5.0" | ||
| "@types/node": "25.5.0", | ||
| "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.4fd595565e1b44be3b8218943e0ec5ae7d08889d" | ||
| }, |
There was a problem hiding this comment.
The package imports defineConfig from vite-plus in its vite.config.ts, but vite-plus is not declared in its devDependencies. To prevent phantom dependency issues and ensure reliable dependency resolution and task tracking in the monorepo, please add "vite-plus": "catalog:" to devDependencies.
| "devDependencies": { | |
| "@faker-js/faker": "10.4.0", | |
| "@types/node": "25.5.0" | |
| "@types/node": "25.5.0", | |
| "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.4fd595565e1b44be3b8218943e0ec5ae7d08889d" | |
| }, | |
| "devDependencies": { | |
| "@faker-js/faker": "10.4.0", | |
| "@types/node": "25.5.0", | |
| "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.4fd595565e1b44be3b8218943e0ec5ae7d08889d", | |
| "vite-plus": "catalog:" | |
| }, |
| "devDependencies": { | ||
| "@faker-js/faker": "10.4.0", | ||
| "@types/node": "25.5.0", | ||
| "@xmldom/xmldom": "0.9.9", | ||
| "fflate": "0.8.2", | ||
| "vitest": "4.1.2" | ||
| "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.4fd595565e1b44be3b8218943e0ec5ae7d08889d" | ||
| } |
There was a problem hiding this comment.
The package imports vite-plus/test in its test files and runs vp test run in its scripts, but vite-plus is not declared in its devDependencies. To prevent phantom dependency issues and ensure reliable dependency resolution and task tracking in the monorepo, please add "vite-plus": "catalog:" to devDependencies.
"devDependencies": {
"@faker-js/faker": "10.4.0",
"@types/node": "25.5.0",
"@xmldom/xmldom": "0.9.9",
"fflate": "0.8.2",
"vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.4fd595565e1b44be3b8218943e0ec5ae7d08889d",
"vite-plus": "catalog:"
}
No description provided.