Skip to content

vp migrate beta test#3

Draft
fengmk2 wants to merge 2 commits into
mainfrom
vp-migrate-test
Draft

vp migrate beta test#3
fengmk2 wants to merge 2 commits into
mainfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 29, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures the project to use Vite+ and OXC, updating VS Code settings, simplifying the AGENTS.md documentation, adjusting TypeScript path mappings in apps/portal/tsconfig.json, and adding a vite.config.ts configuration for the portal app. Additionally, dependency catalogs in pnpm-workspace.yaml and package.json are updated to pin specific commit versions of Vite+ core. Regarding feedback, the configuration path oxc.fmt.configPath in .vscode/settings.json is set to ./vite.config.ts, but there is no vite.config.ts at the root of the monorepo (only inside apps/portal/), which may cause the OXC VS Code extension to fail to find the configuration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .vscode/settings.json
Comment on lines +33 to +34
},
"oxc.fmt.configPath": "./vite.config.ts"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The configuration path oxc.fmt.configPath is set to ./vite.config.ts, but there is no vite.config.ts file at the root of this monorepo (the only configuration file is located at apps/portal/vite.config.ts). This will cause the OXC VS Code extension to fail to find the configuration file, potentially breaking formatting. Consider removing this setting to let the extension auto-detect the configuration, or update it to the correct path.

  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant