vp migrate beta test#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates Vite+ into the project, adding configuration files for VS Code, updating documentation, and switching dependencies and imports to Vite+. Feedback highlights two critical issues: first, importing types from vite-plus instead of vite in a published library file will cause compilation errors for consumers who do not use Vite+; second, pinning dependencies to temporary commit-specific versions from pkg.pr.new poses a risk to long-term build stability and reproducibility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| import { Buffer } from 'node:buffer' | ||
| import process from 'node:process' | ||
| import type { HmrContext, Plugin, ViteDevServer } from 'vite' | ||
| import type { HmrContext, Plugin, ViteDevServer } from 'vite-plus' |
There was a problem hiding this comment.
Importing types from vite-plus instead of vite in a published library file will cause issues for consumers of this package. Since vite-plus is only a devDependency and not a dependency or peerDependency, consumers who do not use vite-plus will get compilation/type resolution errors (e.g., Cannot find module 'vite-plus') when they import ./live-examples.\n\nTo ensure compatibility with all Vite users, keep importing the types from 'vite'.
| import type { HmrContext, Plugin, ViteDevServer } from 'vite-plus' | |
| import type { HmrContext, Plugin, ViteDevServer } from 'vite' |
| "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442", | ||
| "vite-plus": "0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442", |
There was a problem hiding this comment.
Using temporary commit-specific versions from pkg.pr.new (e.g., 0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442) for vite and vite-plus in package.json is highly risky for long-term maintainability. These packages are temporary and can be garbage-collected or deleted from the registry bridge, which will eventually break local installations and CI builds for anyone cloning this repository in the future.\n\nConsider using official pre-release tags (like alpha or beta versions) published to the main npm registry once they are available, or pin to stable versions if possible.
setup-node's cache probe runs `npm config get cache` with the runner's bundled npm 11.13.0, which hard-errors (EBADDEVENGINES) against the devEngines pin requiring 11.17.0. Disable that probe and upgrade npm before install across all CI jobs. Claude-Session: https://claude.ai/code/session_019EGr8nmWa6FjXRAbv7sTJq
Closes #issue.
Summary of major changes
Todos
Checklist
[ ] has tests (only needed if any new functionality was added or bugs fixed)
[ ] has examples/docs (only needed if any new functionality was added)