vp migrate beta test#10
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project to use Vite+ as the unified toolchain, updating configuration files, VS Code settings, and documentation (AGENTS.md). It updates package dependencies and type declarations to reference vite-plus instead of vite, and locks catalog versions to a specific commit. The review feedback suggests improving type accuracy in packages/vite-plugin-remdx/index.d.ts by returning Plugin instead of PluginOption to match the implementation in index.ts.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| import type { PluginOption } from 'vite-plus'; | ||
|
|
||
| export default function remdx(): PluginOption; |
There was a problem hiding this comment.
For better type accuracy and consistency with the implementation in index.ts (which returns Plugin), the declaration file should also return Plugin instead of the wider PluginOption type. This ensures that consumers of the plugin get the most precise type definition without unnecessary union types.
| import type { PluginOption } from 'vite-plus'; | |
| export default function remdx(): PluginOption; | |
| import type { Plugin } from 'vite-plus'; | |
| export default function remdx(): Plugin; |
No description provided.