vp migrate beta test#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the repository to Vite+, a unified toolchain, replacing tsdown and standard vite/vitest configurations with vp commands and vite-plus imports across various packages and test files. Feedback highlights a redundant vp config execution in the prepare script of package.json and warns against replacing vite with vite-plus in the downloadable playground template, which would cause runtime errors for end-users.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }, | ||
| "scripts": { | ||
| "prepare": "FORCE_COLOR=1 turbo run turbo:postinstall", | ||
| "prepare": "vp config && FORCE_COLOR=1 turbo run turbo:postinstall", |
There was a problem hiding this comment.
The prepare script executes vp config before running turbo run turbo:postinstall. Since turbo:postinstall already executes vp config internally, this leads to vp config being run twice during the installation process. Consider removing the redundant vp config call from the prepare script to optimize the setup workflow.
| "prepare": "vp config && FORCE_COLOR=1 turbo run turbo:postinstall", | |
| "prepare": "FORCE_COLOR=1 turbo run turbo:postinstall", |
| @@ -1,4 +1,4 @@ | |||
| import { defineConfig } from 'vite'; | |||
| import { defineConfig } from 'vite-plus'; | |||
There was a problem hiding this comment.
Changing the import in the downloadable playground template from vite to vite-plus will cause runtime errors for end-users unless vite-plus is added to the template's package.json dependencies. Furthermore, forcing external playground users to use vite-plus instead of standard vite may be unintended. It is recommended to keep standard vite for the downloadable template.
| import { defineConfig } from 'vite-plus'; | |
| import { defineConfig } from 'vite'; |
No description provided.