vp migrate beta test#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the repository to use pnpm catalogs for managing vite, vitest, and vite-plus dependencies, updates VS Code settings to use the Oxc formatter, and adjusts imports in various test files to use vite-plus. Feedback on these changes highlights two issues: first, the vitest catalog entry in pnpm-workspace.yaml is set to a standard version (4.1.9) instead of the custom vite-plus-test integration package, which breaks the override mapping; second, modifying the dependency array in the MutableInDepsComponent test fixture to [] defeats the purpose of testing mutable dependencies.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| - unrs-resolver | ||
| catalog: | ||
| vite: npm:@voidzero-dev/vite-plus-core@0.0.0-commit.4be8d5190ff1283cef27bcb957cf313891fd1269 | ||
| vitest: 4.1.9 |
There was a problem hiding this comment.
In the previous configuration, vitest was overridden to npm:@voidzero-dev/vite-plus-test@^0.1.15. With the new catalog setup, vitest is set to 4.1.9, which is a standard vitest version rather than the vite-plus-test integration package. This will break the override mapping. It should be updated to point to the corresponding vite-plus-test commit-hash version.
vitest: npm:@voidzero-dev/vite-plus-test@0.0.0-commit.4be8d5190ff1283cef27bcb957cf313891fd1269| useEffect(() => { | ||
| document.title = location.pathname; | ||
| }, [location.pathname]); | ||
| }, []); |
There was a problem hiding this comment.
The component MutableInDepsComponent in this test fixture seems specifically designed to test how the linter handles mutable values (like location.pathname) in the useEffect dependency array. Changing the dependency array to [] removes the mutable dependency, which likely defeats the purpose of this test fixture and reduces test coverage for this rule. If this was changed to suppress a lint error during migration, consider using a lint suppression comment instead of modifying the test fixture's behavior.
| }, []); | |
| }, [location.pathname]); |
commit: |
No description provided.