vp migrate beta test#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request configures the project to use Vite+ by adding documentation, a Vue module declaration, and migrating dependencies to a pnpm catalog. Feedback points out that the overrides field is not supported in pnpm-workspace.yaml and must be moved to the root package.json under pnpm.overrides to ensure transitive dependencies are correctly resolved.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| overrides: | ||
| vite: 'catalog:' | ||
| catalog: | ||
| vite: npm:@voidzero-dev/vite-plus-core@0.0.0-commit.5b214b7987c99adfe0aff4d406264457ed0232ce | ||
| vite-plus: 0.0.0-commit.5b214b7987c99adfe0aff4d406264457ed0232ce | ||
| peerDependencyRules: | ||
| allowAny: | ||
| - vite | ||
| allowedVersions: | ||
| vite: '*' |
There was a problem hiding this comment.
In pnpm, the overrides field is not supported at the root level of pnpm-workspace.yaml. It must be defined in the root package.json under the pnpm.overrides block. Defining it here will cause pnpm to ignore the override, which means transitive dependencies depending on vite will not be resolved to the catalog version.
catalog:
vite: npm:@voidzero-dev/vite-plus-core@0.0.0-commit.5b214b7987c99adfe0aff4d406264457ed0232ce
vite-plus: 0.0.0-commit.5b214b7987c99adfe0aff4d406264457ed0232ce
peerDependencyRules:
allowAny:
- vite
allowedVersions:
vite: '*'| "packageManager": "pnpm@10.33.0" | ||
| } |
There was a problem hiding this comment.
Add the pnpm.overrides block here to ensure that transitive dependencies depending on vite are correctly overridden to use the cataloged version, since overrides is not supported in pnpm-workspace.yaml.
| "packageManager": "pnpm@10.33.0" | |
| } | |
| "packageManager": "pnpm@10.33.0", | |
| "pnpm": { | |
| "overrides": { | |
| "vite": "catalog:" | |
| } | |
| } | |
| } |
No description provided.