vp migrate beta test#10
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project to the Vite+ unified toolchain, updating package configurations, workspace settings, and test imports to use vite-plus and its catalog features. Feedback on these changes highlights two key issues: first, the catalog: protocol is not supported within the overrides field of pnpm-workspace.yaml and will cause issues; second, changing the CLI binary name from ohbug to cli in packages/ohbug-cli/package.json is highly generic and likely to cause command conflicts on users' systems.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| overrides: | ||
| vite: "catalog:" | ||
| vitest: "catalog:" |
There was a problem hiding this comment.
In pnpm, the catalog: protocol is only supported within the dependencies, devDependencies, and peerDependencies fields of package.json files. It cannot be used inside the overrides field in pnpm-workspace.yaml.
To resolve this, you should specify the exact version or the same alias specifier directly in the overrides.
overrides:
vite: npm:@voidzero-dev/vite-plus-core@0.0.0-commit.e4bb8042a8906a94416439deaacd7dc9ae40ed7a
vitest: 4.1.9| "bin": { | ||
| "ohbug": "dist/ohbug.mjs" | ||
| "cli": "./dist/ohbug.mjs" | ||
| }, |
There was a problem hiding this comment.
Changing the binary name from "ohbug" to "cli" will register a global command named cli when users install @ohbug/cli globally. This is extremely generic and is highly likely to conflict with other command-line tools on the user's system. It also reduces brand recognition. It is recommended to keep "ohbug" as the executable name.
| "bin": { | |
| "ohbug": "dist/ohbug.mjs" | |
| "cli": "./dist/ohbug.mjs" | |
| }, | |
| "bin": { | |
| "ohbug": "./dist/ohbug.mjs" | |
| }, |
rolldown 1.0.0-rc.17 (rolldown/rolldown#9197) turned a missing export between TS modules into a hard error instead of a warning. vp pack bundled webpack's devDependency types into the declarations and descended into postcss/tapable, whose .d.mts re-export their own .d.ts as value imports, which now fails the build (and the postinstall hook, breaking vp install). Mark all third-party packages external in the dts so declarations reference import('vite').Plugin etc. instead of inlining the broken type graphs. Claude-Session: https://claude.ai/code/session_01GjGMDKa7ACMah1hvJsdHzo
No description provided.