vp migrate beta test#8
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces Vite+ integration, including VS Code configurations, documentation, and workspace catalog updates. Feedback focuses on configuration stability: committing a custom registry bridge to .npmrc and using specific commit-hash-based pre-release versions in pnpm-workspace.yaml are both fragile practices that could lead to dependency resolution failures in the future.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # pkg.pr.new registry bridge (added by test-pkg-pr-new-migrate.sh) | ||
| registry=https://pkg-pr-registry-bridge.void.app/ |
There was a problem hiding this comment.
Committing a custom registry bridge (https://pkg-pr-registry-bridge.void.app/) to .npmrc can cause dependency resolution issues for other contributors or in CI environments if the bridge is unstable, slow, or eventually taken down. If this registry is only needed temporarily for testing the migration, it should not be committed to the repository. Consider configuring this registry via a local .npmrc (ignored by git) or via CI environment variables instead.
| vite: npm:@voidzero-dev/vite-plus-core@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 | ||
| vite-plus: 0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 |
There was a problem hiding this comment.
Using a specific commit-hash-based pre-release version (0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442) in the workspace catalog is highly fragile. These temporary packages on pkg.pr.new or custom registries are often pruned or may become unavailable, which will break future installations. Consider using a stable version or a standard pre-release tag (e.g., beta or alpha) once the migration is finalized.
No description provided.