vp migrate beta test#10
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Vite+ toolchain integration, including configuring language-specific VS Code settings for OXC, updating documentation in AGENTS.md and CLAUDE.md, and migrating dependencies like vite and vitest to use pnpm catalogs. It also updates imports in test helpers to use vite-plus/test/context. Feedback on these changes suggests defining the newly added @vitest/browser-playwright dependency in the workspace catalog for consistency. Additionally, there is a security recommendation to keep blockExoticSubdeps enabled to mitigate supply chain risks associated with resolving sub-dependencies from exotic sources.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "vitest-browser-react": "2.2.0" | ||
| "vitest": "catalog:", | ||
| "vitest-browser-react": "2.2.0", | ||
| "@vitest/browser-playwright": "4.1.9" |
There was a problem hiding this comment.
To maintain consistency and make future dependency upgrades easier, consider defining @vitest/browser-playwright in the shared catalog within pnpm-workspace.yaml and referencing it here using catalog:.
| "@vitest/browser-playwright": "4.1.9" | |
| "@vitest/browser-playwright": "catalog:" |
| vitest: npm:@voidzero-dev/vite-plus-test@latest | ||
| vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@dca39038de6ca46e523bf64dc09bf100b636eea9 | ||
| vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@dca39038de6ca46e523bf64dc09bf100b636eea9 | ||
| vitest: 4.1.9 |
There was a problem hiding this comment.
Add @vitest/browser-playwright to the catalog to match the reference in package.json.
vitest: 4.1.9
"@vitest/browser-playwright": 4.1.9| allowedVersions: | ||
| vite: '*' | ||
| vitest: '*' | ||
| blockExoticSubdeps: false |
There was a problem hiding this comment.
Disabling blockExoticSubdeps (by setting it to false) allows sub-dependencies to be resolved from exotic sources (like git, local files, etc.), which can increase the risk of supply chain attacks. If none of the workspace dependencies strictly require exotic sub-dependencies, it is highly recommended to keep this enabled (true) for better security.
No description provided.