vp migrate beta test#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project's testing and build configuration to use vite-plus. This includes updating test imports from vitest to vite-plus/test across all test files, configuring a pre-commit hook, and centralizing dependency management using pnpm catalogs. Feedback on these changes highlights a security risk in .npmrc where the global registry is overridden instead of scoped, a missing shebang in the pre-commit hook, and a recommendation to catalog @vitest/coverage-v8 for consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -0,0 +1,2 @@ | |||
| # pkg.pr.new registry bridge (added by test-pkg-pr-new-migrate.sh) | |||
| registry=https://pkg-pr-registry-bridge.void.app/ | |||
There was a problem hiding this comment.
Overriding the global registry to a custom bridge (https://pkg-pr-registry-bridge.void.app/) poses security and reliability risks. All dependencies (not just @voidzero-dev or vite-plus packages) will be routed through this bridge, which could lead to dependency confusion, MITM attacks, or build failures if the bridge is down. If this bridge is only needed for specific scoped packages, scope the registry in .npmrc.
@voidzero-dev:registry=https://pkg-pr-registry-bridge.void.app/
| @@ -0,0 +1 @@ | |||
| vp staged | |||
There was a problem hiding this comment.
Git hooks and pre-commit scripts should include a shebang (e.g., #!/bin/sh) to ensure they are executed correctly across different shells and operating systems.
#!/bin/sh
vp staged
| "@vitest/coverage-v8": "^4.1.7", | ||
| "vite-plus": "^0.2.0", | ||
| "vitest": "^4.1.5" | ||
| "@vitest/coverage-v8": "4.1.9", |
There was a problem hiding this comment.
To maintain consistency and centralize dependency version management, consider defining @vitest/coverage-v8 in the catalog of pnpm-workspace.yaml and referencing it here using catalog:.
| "@vitest/coverage-v8": "4.1.9", | |
| "@vitest/coverage-v8": "catalog:", |
No description provided.