vp migrate beta test#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project to the Vite+ unified toolchain, updating dependencies, configuration files, and test imports across multiple packages to use vite-plus. It also applies extensive formatting updates to Svelte components. The review feedback highlights two key issues: an invalid Node.js engine version requirement (>=24.11.0) in package.json and the accidental commitment of a temporary registry bridge in .npmrc.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }, | ||
| "engines": { | ||
| "node": ">=24" | ||
| "node": ">=24.11.0" |
There was a problem hiding this comment.
The Node.js version requirement is set to >=24.11.0. However, Node.js version 24 has not been released yet (Node.js 22 is the current LTS, and Node.js 23 is the current active release). This requirement will prevent installation in standard environments. Did you mean >=22.11.0 or >=20.11.0?
| "node": ">=24.11.0" | |
| "node": ">=22.11.0" |
| @@ -0,0 +1,2 @@ | |||
| # pkg.pr.new registry bridge (added by test-pkg-pr-new-migrate.sh) | |||
| registry=https://pkg-pr-registry-bridge.void.app/ | |||
There was a problem hiding this comment.
Committing a custom registry pointing to a temporary bridge registry (https://pkg-pr-registry-bridge.void.app/) in .npmrc can cause dependency resolution issues, slowness, or security risks for other contributors and standard CI environments. This registry configuration appears to have been added automatically by a test script (test-pkg-pr-new-migrate.sh) and should be removed or commented out before merging.
# registry=https://pkg-pr-registry-bridge.void.app/
No description provided.